Design comparison
SolutionDesign
Solution retrospective
No major questions for this project. Just wanted to knock out a simpler project and try to make everything responsive without using media queries.
Community feedback
- @denieldenPosted almost 2 years ago
Hello Markus, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - use
min-height: 100vh
to body instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0@mhjarvisPosted almost 2 years ago@denielden Thanks for the feedback, I've not used the transition element, so will look into adding that to my library.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord