NFT Preview Card

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…

  • Adjust the padding in .card rule set from padding: 1.5rem 1.6rem 2rem; into padding: 1rem 0;
  • Use semantic tags, for HTML structures, refer it with this one Semantics . Alternative is to wrap this line <div class="card"> with section tag. Since it has a hover state, might as well use a tag for the link
  • Wrap this line <div class="attribution"> with footer tag or place it inside the main tag
  • Aside from using hr for the border line. Alternative way is to use border-top: 1px solid 'color value'; in the class="creator"

  Above all, Well done! Keep it going!

  Marked as helpful

  0

  ---

  

  Borko•230

  @borkk85Posted almost 3 years ago

  @RioCantre Thanks for the feedback, it's been very helpful while I'm trying to get my head wrapped around writing well structured code...

  0