@Hassiai
Posted
Replace <div class="card"> with the main tag, <h3> with <p> to fix the accessibility issues. click here for more on web-accessibility and semantic html.
To center .card on the page using flexbox or grid instead of margin,
- USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
- USING GRID: Add min-height:100vh; display: grid place-items: center to the body
body{
min-height: 100vh;
display: grid;
place-items: center;
}
There is no need to give the body a margin value.
For a responsive content which wont require a media query for this challenge, give .card a fixed max-width value and a padding value for all the sides. max-width:400px which is 25rem/em and padding:16px 1rem/em
Give .container and the img a width of 100%.
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
