Design comparison
SolutionDesign
Community feedback
- @AlexKMarshallPosted about 3 years ago
This looks good. There are just a couple of issues.
Semantics are mostly correct. But the hover effect on the
<h1>
implies it should have an anchor inside it as it's a link.The image overlay should either be a button or a link, again as it's implying some kind of interactivity.
Avoid using
px
units for font-sizes. We want our fonts to scale when the user changes their base font size so always userem
orem
.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord