@yannmarc
Posted
Hello 👋🏼
I love your work.
But I got some few remarks to make:
-
Your HTML is not semantic which is probably why you are getting some accessibilities issues with your work. To cover this up, try using landmarks for; your container
div
should have arole = main or container
like wise for any sections of your code to give it some semantic for screen readers. -
Your layout looks big on big screens, I went through you CSS code and your body has a
max-width: 1440px
which should be applied to the container. unlike other CSS library thiscontainer has max-width: 1100px
-
Your code structure is good but try commenting where necessary it can be useful to us reading your code.
-
Try using CSS resets to ease your workflow example
img { width: 100%; object-fit: cover; }
Marked as helpful