Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card

P

@JlordS32

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Made in about 20 minutes

Community feedback

@DivineUgorji

Posted

Congratulations on finishing this challenge, and very fast too, however, I couldn't help but notice a few things that can make the project better.

  • First, I observed that you did not implement the hover state for the image, the card title, and the creator's name. I wouldn't know if that was intentional.

  • I also observed that both your HTML and CSS are in the same file. It's always a good practice to separate them into different files for better organization, reusability of code snippets, and separation of concerns.

  • You can also add a little padding to the card to prevent it from touching the top and bottom of the browser.

Happy coding!

1

P

@JlordS32

Posted

@DivineUgorji Thanks for the feedback, I have updated the code. I seem to have missed the hover state my bad.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord