NFT Preview Card

Community feedback

• 

  hamza•390

  @HamzaouladevPosted over 1 year ago

  hello @AnaLuisaFav, here are some suggestions i hope you'll find helpful

  -its almost always better not to give your components a fixed height, because youll end up with content overflowing in small screens, its better to remove the height from the container class.

  -in the footer, id suggest using flexbox here for managing the layout with a gap spacing instead of the span padding:

  .final {
      display: flex;
      align-items: center;
      gap: 1rem;
  }
  

  -also id recommend using more semantic html tags in your code, and providing alt values for images when needed, i invite you to read up on these topics here: Semantic HTML5 Elements Explained What is Alt Text?

  hope you found my feedback helpful, keep hacking!

  Marked as helpful

  1

  ---

  

  Ana Luisa•290

  @AnaLuisaFavPosted over 1 year ago

  @Hamzaouladev thank you! I'll fix it 😃

  0
• 

  Pipow•500

  @PipouwPieuwPosted over 1 year ago

  Hello 👋 Well done here, your hover effect looks neat!

  I have a few remarks:

  • You applied the equilibrium image as a background but as it is not a purely decorative image, you should use an <img> tag instead.
  • You always need to have a <h1> on your page. This adds meaning to your page and shows what the main topic is. Here, the <h1> should be Equilibrium #3429. You can of course keep the <a> wrapped inside or around the <h1> :)

  Keep going 🎉

  Marked as helpful

  0

  ---

  

  Ana Luisa•290

  @AnaLuisaFavPosted over 1 year ago

  @PipouwPieuw thank you for help!! I'll fix it 😁😁

  0