Design comparison
Solution retrospective
Hi!, I accept constructive opinions to improve.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hello, Sandlerz! 👋
Congratulations on finishing this challenge! 🎉
I have some feedback on this solution:
- Accessibility
- The equilibrium image should be wrapped with an interactive element, which in this case,
a
element because it has a:active
states. - All page content should live inside the landmark including the equilibrium image.
- Use
rem
or sometimesem
unit instead ofpx
. Usingpx
will not allow the users to control the size of the page based on their needs.
- The equilibrium image should be wrapped with an interactive element, which in this case,
- Styling
- Don't limit the height of the
body
element, it will not allow the users to scroll the page if the page content needs moreheight
. Usemin-height
instead. - Also, I would not recommend specifying the
height
of any element in this case. In the real world, the page content might change over time, whether you adding or removing content. If you specify the height of the element, then you should always adjust theheight
every time the page content is changing. - I would recommend letting the content inside the card dictate the height of it.
- Don't limit the height of the
- Best Practices (Recommended)
- Always use classes to reference all the elements that you want to style. Using
id
is going to make your stylesheet have high specificity (hard to maintain).
- Always use classes to reference all the elements that you want to style. Using
That's it! Hopefully, this is helpful! 😁
Marked as helpful1@sandlerzPosted over 2 years ago@vanzasetia thanks very much vanza for that huge feedback. I'm putting in practices all of those things.
1 - Accessibility
- @NaveenGumastePosted over 2 years ago
Hay ! Good Job sandlerz
These below mentioned tricks will help you remove any Accessibility Issues
-> Add
Main
tag after body like it should be your container. For 1st heading orh1
tag, use header tag and then inside the header put yourh1
orh2
etc . But use header tag only once in main heading element.Keep up the good work!
Marked as helpful1@sandlerzPosted over 2 years ago@Crazimonk Thanks for comment Naveen, I'm going to do that on the current project and look up for more information about Accessibility.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord