Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card

Adriel Murrayโ€ข 90

@AdrielMurray

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Learned how to use box shadows and the hover selector. Any advice for cleaner code? What can I improve next time?

Community feedback

Lucas ๐Ÿ‘พโ€ข 104,420

@correlucas

Posted

๐Ÿ‘พHello Adriel, congratulations for your solution!

About your code, you can do only a little fix, changing between <div> to <main> wrapping all the content there, the rest you've used only the necessary elements. For the next challenges you can think about using more semantic block elements as <main> <section> and <article>.

Note that you nft image is overlapping the container, try to work this image applying the property display: block; and max-width: 100%; to keep the image inside the container and growing 100% of its size.

Hope it helps you, and happy coding!

Marked as helpful

0
Prince Royโ€ข 1,210

@iprinceroyy

Posted

That's great @AdrielMurray. You need to focus on some key points here:-

  1. There should be one heading tag on a web page, if there is no heading element requirement, then set its font size to 0. h1{ font-size: 0; }
  2. The content should be wrapped inside the main landmark to avoid accessibility issues. Like this <body><main>your content goes here......</main></body>.
  3. Set the equilibrium image's width & height to 100%. Some margins around the left & right.
  4. Set nft-card & nft-image width: 100% .nft-card{ width: 100%; overflow: hidden; } .nft-image{ width: 100%; }

Hope it adds to your learning. Happy coding :)

Marked as helpful

0

Adriel Murrayโ€ข 90

@AdrielMurray

Posted

@iprinceroyy thanks for the advice

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord