Design comparison
Solution retrospective
I found it difficult to add overlay to the card, also to show the view icon while hovering the card, I didn't manage though
Community feedback
- @VCaramesPosted about 2 years ago
Hey @boibolang, some suggestions to improve you code:
-
Stay away from IDs when naming your content. They are not reusable and are mainly used for JavaScript. Its best practice to use, Classes for your naming convention as classes are reusable, making them ideal for CSS styling.
-
To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
<body> <main> <article class=“card-container”></article> </main> </body>
The Main Element identifies the main content of the document.
While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.
More info:
https://web.dev/learn/html/headings-and-sections/
-
The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
The hover effect was not applied. Here is a link that can show you how to do it:
https://www.w3schools.com/howto/howto_css_image_overlay.asp
Happy Coding! 👻🎃
Marked as helpful0@genos-uxPosted about 2 years ago@vcarames The clock symbol is slightly on top think you should try using CSS flexbox ... could help you around center everything.
Marked as helpful0@VCaramesPosted about 2 years ago@genos-ux
That would fix it.
#ether, #clock { display: flex; align-items: center; }
To center you card to the page, you can add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center; }
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord