Design comparison
SolutionDesign
Community feedback
- @lack21Posted over 1 year ago
Great work 👍, but I have a recommendation!
- Replace
height: 100vh
tomin-height: 100vh
in thediv
, the difference is that, when you setheight: 100vh
to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to setmin-height: 100vh
, like this in case content is overflowing container will adjust to it!
1@SchismondPosted over 1 year ago@lack21 thanks for the advice, I'm aware about the min-height attribute I left it at height: 100vh knowing that I won't fall into overflowing problem , but prevention is better than cure. thanks for your advice
1 - Replace
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord