NFT Preview Card

Community feedback

• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋, in case you want to take a look:

  HTML, ACCESSIBILITY:

  • The main content of every page (the card in this case) should be wrapped with the <main> tag.

  • Every page should have an <h1> to improve user experience and because it is an important element when it comes to SEO. It is not a good idea to skip heading levels.

  • The Equilibrium image is a meaningful image and therefore should not be a background-image, should have an alt text with a description in case the user can't see it.

  • On the other hand, the icons are decorative images and therefore need an empty alt attribute to be ignored by a screen reader.

  CSS:

  • When there is a hover state over an element it means that it is interactive, so there must be an interactive element around it (like a link or a button). So, we should use a <a> or <button> to wrap the image (depending on what happened when clicking on it). Also 'Equilibrium #3429' and 'Jules Wyvern' should be wrapped with the <a> tag.

  Please let me know if you want more info on any of these topics or disagree with something. I hope it’s useful 🙂

  Regards,

  0

  ---

  

  Sahil Atahar•260

  @sahilataharPosted over 1 year ago

  @fernandolapaz Thanks for these helpful information.

  0

  

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  @sahilatahar You are welcome : )

  0