@PhoenixDev22
Posted
Hi Aman,
Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:
HTML
- Page should contain a level-one heading. In this challenge , as itβs not a whole page, and you can use
<h1>
with class sr-only aiming at visually hiding the element while keeping it accessible to assistive technologies
- The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..)
for this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use
<button>
. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use<a>
.
For the same reason, you can use <a>
to wrap Equilibrium #3429
.
- The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you.
- For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in( icon-ethereum, icon-clock ).
- Profile images like that avatar are valuable content. The alternate text of the avatarβs image should not be ** image-avatar**. You can use the creator's name
Jules Wyvern
. Read more how to write an alt text
- If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<hr>
, you can useborder-top:
to the avatar's part.
- There are so many ways to do the hover effect on the image, The one I would use is pseudo elements
::before, ::after
. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.
hopefully this feedback helps.
Marked as helpful
@AmanGupta1703
Posted
@PhoenixDev22 Thank you! π
@PhoenixDev22
Posted
@AmanGupta1703
Happy coding!
Marked as helpful