NFT Preview Card

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Aman,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • Page should contain a level-one heading. In this challenge , as it’s not a whole page, and you can use <h1> with class sr-only aiming at visually hiding the element while keeping it accessible to assistive technologies

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason, you can use <a> to wrap Equilibrium #3429 .

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in ( icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be ** image-avatar**. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Aman•630

  @AmanGupta1703Posted about 2 years ago

  @PhoenixDev22 Thank you! 😊

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @AmanGupta1703

  Happy coding!

  Marked as helpful

  1
• 

  imad•3,330

  @imadvvPosted about 2 years ago

  Greeting Aman!! Congratulations for completing your challenge!, 👏👏👏 well done.

  you did great on challenge, and you so close to archive that hover effect,

  I did some changes to make it work for you, helpfully you found it useful.

  • style.css line 68*

  .nft-banner {
      cursor: pointer;
      position: relative;
      background-color: hsl(178, 100%, 50%);
      overflow: hidden;
      border-radius: 10px;
  
  }
  
  .equilibrium-img{
      width: 100%;
      display: block;
      transition: opacity 250ms ease-in-out;
  }
  
  
  .nft-banner::after {
      content: url(../images/icon-view.svg);
      position: absolute;
      z-index: 1;
      inset: 0;
      display: flex;
      justify-content: center;
      align-items: center;
      opacity: 0;
      transition: opacity 0.5 ease-in-out;
  }
  
  .nft-banner:hover .equilibrium-img {
   opacity: 0.55;
  }
  
  .nft-banner:hover::after {
      opacity: 1;
  
  }
  
  

  and here you have it, Hope this can give you some hints!!

  overall Great attempt, Happy Codding, and Have a Good Day/Night

  Marked as helpful

  1

  ---

  

  Aman•630

  @AmanGupta1703Posted about 2 years ago

  @imadbg01 Thank you! 😊

  1

  

  imad•3,330

  @imadvvPosted about 2 years ago

  @AmanGupta1703 You're More than Welcome

  Marked as helpful

  1
• 

  Loo_cee•230

  @LooceePosted about 2 years ago

  Hey, great job on replicating. Well to get the hover effect correctly, you have to set the nft image as the background image for the div and then using a before pseudo class, set the content of the div as " " . Then you can add an hover effect to the pseudo class and set your background image and color. I hope this helps.

  Marked as helpful

  1

  ---

  

  Aman•630

  @AmanGupta1703Posted about 2 years ago

  @Loocee Thank you! 😊

  1