Design comparison
Solution retrospective
Any feedback would be appreciated.
Community feedback
- @denieldenPosted over 2 years ago
Hi Sami, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - add descriptive text in the
alt
attribute of the image - You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
Overall you did well 😉
Hope this help and happy coding!
Marked as helpful1 - add
- Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
-
you can add the image and background color on hover with pseudo elements
:before & ::after
if you are not sure what i am talking about you can learn from my solution -
check the HTML report to fix accesibility issues
i hope this is helpful and goodluck
Marked as helpful0@SilverWings47Posted over 2 years ago@Old1337 Thank you, i added the background image using
::before
and `::after1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord