NFT preview card

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Aya Saeed! 👋

  Nice work on this challenge! 🙌 Your solution is responsive and looks great! 👍

  Two things can be done better.

  • I recommend coding your font size in rem, not pixels. This means the text size will be responsive if people want to adjust the size.
  • Alternative text for images should not contain any words that are related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image. Also, not all images need alternative text. In this case, those icons are decorative images so I recommend leaving the alt="" empty to hide those images from screenreader users.

  Hope this helps. 🙂

  1

  ---

  

  Aya Saeed•1,020

  @Aya-Saeed261Posted over 2 years ago

  @vanzasetia Thank you so much for your feedback. I normally use rem but sometimes when I want the font size less than 16px or when I'm too lazy to do the math, I just use pixels. But from now on I'll stick to rem. Thanks again.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Aya-Saeed261 It's okay! Once you get used to it then calculating px values to rem values would be the part of writing CSS. 😅

  But, if you will use Sass in the future, you can create a rem() function that will help you convert any px values to rem values.

  // In Sass
  body {
    font-size: rem(16);
  }
  
  // In CSS
  body {
    font-size: 1rem;
  }
  

  1
• 

  Macaulay Omoikhoje De-great•550

  @MacChristoPosted over 2 years ago

  Adding a box-shadow will be nice

  1

  ---

  

  Aya Saeed•1,020

  @Aya-Saeed261Posted over 2 years ago

  @MacChristo I haven't noticed that in the design the card had a box-shadow, thank you for pointing that out.

  0