NFT Preview Card

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Hello @JJOosthuizen ,

  I have some suggestions regarding your solution :

  • Anything with a hover style in a design means it's interactive. you need to add an interactive element around the image and Equilibrium #342 and Jules Wyvern.

  • For any decorative images, each img tag should have empty alt="" andaria-hidden="true"attributes to make all web assistive technologies such as screen reader ignore those images in alt="alt="clock", alt="ethereum".

  • the link should be wrapping the original image and either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • The avatar's alt text shouldn't be only avatar. You can use Jules Wyvern as an alt text.

  • You can read more about alt text

  • text should never be in or spans alone. Use a meaningful element

  • You can use an unordered list <ul> for class="container and in each <li>, there would be <img> and <p>

  • nesting css selectors is really a good thing . Really important to keep css specificity as low/flat as possible. The best way to do that is single class selectors

  • You can give the card max-width instead of width.

  Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Jacques•110

  @JJOosthuizenPosted almost 3 years ago

  Hello @PhoenixDev22 ,

  Thank you for taking the time to look at this, giving feedback and pointing out where I can improve. I'll take this and improve on my solutions. 😁

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Jacques Good Job on challenge

  0