NFT preview card

Community feedback

• 

  Guerinik Abderrahmane•480

  @AbderrahmaneGuerinikPosted about 1 year ago

  Nice work ! here are some suggestions to improve your code :

  • use rem rather then px unit.

  • ** in CSS you should use classes, ** you will use id in javascript and its better to give a class to every element in html.

  • you should learn BEM méthodologie for naming classes in CSS BEM

  Marked as helpful

  0

  ---

  

  Carlos Eduardo Riese•80

  @carlosriesePosted about 1 year ago

  Thank you @AbderrahmaneGuerinik! I will check it out this BEM méthodologie.

  0
• 

  P

  Lo-Deck•2,790

  @Lo-DeckPosted about 1 year ago

  Hi well done for this challenge.

  I took a look at your code and change this :

  main#container > a#image > img {
      display: block;
      max-width: 100%;
      border-radius: 10px;
  }
  

  And I didn't have the decrease effect. Here a link for the image.freecodecamp.org.

  And don't use px use em or rem instead. freecodecamp.org

  Hope tobe helpful.

  Marked as helpful

  0

  ---

  

  Carlos Eduardo Riese•80

  @carlosriesePosted about 1 year ago

  Hi @Lo-Deck, im grateful for your help, problem solved. im studyng html and css for a couple months and learning a lot with these challenges. Sometimes i get stuck on it but its very good to know to the community is helpfull with rookies like me. tks a lot!

  0