Design comparison
Solution retrospective
I wasn't able to get the avatar image sized right. Other than that it seemed easy.
Community feedback
- @PhoenixDev22Posted about 2 years ago
Hi Neil Kanakia,
Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:
HTML
- The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use
<button>
.2:If clicking the image would navigate the user to another page to see the NFT, here use
<a>
.- You should have used
<a>
to wrapEquilibrium #3429 and Jules Wyvern
too.
- For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock
).
- The link wrapping the equilibrium image (
image-equilibrium
) should either haveSr-only
text, anaria-label
that indicates where the link navigate the user(not describes the image).
- Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be avatar. You can use the creator's name
Jules Wyvern
. Read more how to write an alt text
- If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<hr>
, you can useborder-top:
to the avatar's part.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site usingtarget=”_blank”
attribute , you can expose your site to performance and security issues.
- There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.
Hopefully this feedback helps.
Marked as helpful0 - @correlucasPosted about 2 years ago
👾Hello Neil, congratulations for your new solution!
Often all you've to do is to use
max-width: 100%
anddisplay: block
but in this case you've to give the image both sizes,here you need to indicate height and width. See the code below:.price img { Max-width: 0.5rem; Max-height: 0.5rem; }
✌️ I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord