NFT Preview Card

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello voffee,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • You have misused the <article> tag.<article> is is intended to be independently distributable or reusable on the dpcumet. In this challenge, it’s all one component. Maybe I would use<article> for the whole component.

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason , you can use <a> to wrap Equilibrium #3429.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be profile-headshot. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view does not really need to be in the HTML as there is no need for an extra clutter in the HTML. You can use CSS for it.

  Overall, great job on this one. Hopefully this feedback helps.

  Marked as helpful

  2

  ---

  

  voffee•70

  @voffeePosted over 2 years ago

  @PhoenixDev22 Thank so much for this detailed response! I will definitely follow what you recommended, it did not occur to me that alt text had a recommended guide, I thought it wasn't important!

  I'm interested in accessibility issues as well, it's a pet project of mine.

  Thanks again! :)

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @voffee Glad to hear that it was helpful. Happy coding!

  1
• 

  imad•3,330

  @imadvvPosted over 2 years ago

  Greeting voffee!! Congratulations on completing Your challenge!,

  if i have to give one resource to learn everything about flex and became good at it, it well be this article A Complete Guide to Flexbox, from css-tricks, just give it a hour or so, to go trough it, and use it as a reference for future project as needed.

  and for this project to center the card on the middle of the page you need to add min-height: 100vh; to the body.

  but over all you did great job on this one ,happy Codding, and have a good day/night

  Marked as helpful

  1