Design comparison
Solution retrospective
let me know what is your advice
Community feedback
- @macdeeshPosted over 2 years ago
Hello Muhamad, that looks pretty good. I really liked the box-shadow and the transition that you used. One more thing that you can improve, wrap the Equilibrium or the NFT image with anchor tag. It has :hover state, which means that it should be an interactive element. It also applies the other elements that have :hover state. I would recommend using pseudo-element to create the overlay for the view icon, like you used for the other SVGs. That way, you can remove the decorative elements from the HTML structure. Additionally, you should have no text in spans alone. Always use meaningful elements, like paragraphs, headings, lists etc. And finally, you need to look up how to write good alt text. You shouldn't be using words like image or hyphenated phrases as if it's code, it is a human-readable description.
Marked as helpful0@bodashideungPosted over 2 years ago@macdeesh wow, thanks for your great advice mate. it's very insightful for me!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord