Design comparison
SolutionDesign
Solution retrospective
Are there better practices I could have used to make this look even better?
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Daniel, Congratulations on completing this challenge... You have some
accessibility issues
that need to fix.Document should have one main landmark
, Contain the component in<main>
.
<main> <div class="container"> //... </div > </main>
Page should contain a level-one heading
, Changeh3
toh1
You should always have oneh1
per page of the document...All page content should be contained by landmarks
, Contain the attribution in<footer>
.
<footer> <div class="attribution"> //... </div> </footer>
I hope this is useful to you... Keep coding👍
Marked as helpful0@Catalyst497Posted over 2 years ago@Bayoumi-dev Thank you so much for the feedback. I love every opportunity I get to improve. Thank you for the feedback once again.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord