NFT PREVIEW CARD

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello again 👋. Good job on completing the challenge !

  • The width: 100vw property in the body tag is not necessary. This will create a horizontal scrollbar on some devices.

  • Exactly the same as in QR code component, no text should be only div, and also the suggestion of height: 100vh

  • You should wrap the image, title, and creator's name in an <a> tag, since an element has a :hover state it is considered an interactive element (buttons, links, etc).

  • You should use the cursor: pointer property to indicate that the element like a button or a link is clickable.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks.

  CSS 🎨:

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  Marked as helpful

  1
• 

  Ritesh_Gupta•520

  @b4n1y4Posted almost 2 years ago

  work on the eye icon on hover

  Marked as helpful

  1