@rayaatta
Posted
Hello jids99👋, congratulations on completing your first FED challenge 🎉
I have some suggestions you might find useful.
1
Try to make your html more Semantic by wrapping the main page content inside a <main> tag .
Replace
<div class="shadow">
With
<main class="shadow">.
This changes nothing visually but
Using it makes all the difference.
Using semantic markup improves
SEO
And user experience (accessibility) for people using assistive technology such as screen readers.
2
I noticed that you used <div class="heading outfit-semibold"> as the top level heading in the document you should replace it with <h1>.
Here's a quick guide on how to headings:
The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.
You can then style them in you css.
Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document
3
Change the Alt attribute of the avatar image to the name of the person on the image.i.e alt="Jules wyvern"
4
I noticed you used plenty of divs and spans to define the different sections of the page. divs do not carry any semantic value.
You should replace them with more semantic tags.
Check out this article 📑
I hope this helps 🙃 Your solution looks awesome Happy coding ✌️
