Design comparison
SolutionDesign
Solution retrospective
Any suggestions for improvement.
Community feedback
- @denieldenPosted over 2 years ago
Hi B Dileep, great work on this challenge! 😉
Here are a few tips for improve your code:
- You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - add
main
tag and wrap the card for improve the Accessibility - using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative - remove all
margin
from.flex-box
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Overall you did well 😁 Hope this help!
Marked as helpful0 - You can add the effect
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord