Skip to content
Submitted almost 3 years ago

NFT Preview

Kevin David•140
@Kevo760
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello Fellow Coders! Coming back from one month of being off on coding due to life events. But I am back at it again. Had to do CSS and HTML first to get the groove back and luckily I still remember most of the knowledge I picked up. Please let me know what I can do to improve on my work. Any feedback is appreciated and helps me develop.

Community feedback

  • namlh•630
    @namlh023Posted almost 3 years ago

    Hello Kevin.

    You did a pretty good job but there is something I want to point out:

    • You don't have to set fix height for your .card.
    • You should have a <main> tag and a <h1> tag in your HTML file (As in accessibility issues). I recommended you change <div class='card'> to <main class='card'> and <h3>Equilibrium #3429</h3> to <h1>Equilibrium #3429</h1>.
    • The avatar image should have border-radius: 50%.
    • You could set the <a href='#'> instead of google.com (That pretty annoying when click in).
    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord