Skip to content
Submitted about 2 years ago

NFT preveiw

Ayush Shukla•70
@isThisAyush
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Adding Pseudo Element with different elements is a little bit tricky though I somewhat managed to do that overall its a nice challenge.

Community feedback

  • Adriano•38,410
    @AdrianoEscarabotePosted about 2 years ago

    Hi Ayush Shukla, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5

    to solve this we can wrap a.card-title with h1

    I noticed that you put inline style in some classes, in this challenge not a problem, but on larger pages, this will be a problem, because if you customize the same class through css, it will end up generating a conflict!

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord