NFT-image-preview-using-scss Public

Community feedback

• 

  HL Wong•290

  @hl-wongPosted 2 months ago

  Hello there. Good job on completing this challenge.

  @media screen and (width <= 768px) {
  	.l-card__shadow {
  		width: 50%;
  	}
  }
  
  @media screen and (max-width: 480px) {
  	.l-card__shadow {
  		width: 80%;
  	}
  }
  

  I just seen your code and preview site. Based on the code above you have write in sass file, I can suggest you to use max-width for your card component.

  <span class="c-card__creator__text">Creation of </span>
  <p class="c-card__creator__name">Jules Wyvern</p>
  

  And this part of code in html, I suggest you should put the <span> tag inside the <p> tag like the code below.

  <p>Creation of <span>Jules Wyvern</span></p>

  Good luck, and happy coding! :D

  Marked as helpful

  0

  ---

  

  Yousef Attia•310

  @Deeperr0Posted 2 months ago

  @hl-wong Thank you for the tip. Is there any particular reason why it is better to have the span tag inside the p tag or is it just the convention?

  0

  

  HL Wong•290

  @hl-wongPosted 2 months ago

  @Deeperr0 Sorry for the late reply. What I know is <span> tag is often used to apply specific style, example like you want to change the color of certain text in the <p> tag, then you need to put <span> tag inside the <p> to change it.

  0