Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT-image-preview-using-scss Public

P

@Deeperr0

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of the speed I developed this in and that I started using SCSS.

Community feedback

HL Wong 290

@hl-wong

Posted

Hello there. Good job on completing this challenge.

@media screen and (width <= 768px) {
	.l-card__shadow {
		width: 50%;
	}
}

@media screen and (max-width: 480px) {
	.l-card__shadow {
		width: 80%;
	}
}

I just seen your code and preview site. Based on the code above you have write in sass file, I can suggest you to use max-width for your card component.

<span class="c-card__creator__text">Creation of </span>
<p class="c-card__creator__name">Jules Wyvern</p>

And this part of code in html, I suggest you should put the <span> tag inside the <p> tag like the code below.

<p>Creation of <span>Jules Wyvern</span></p>

Good luck, and happy coding! :D

Marked as helpful

0

P

@Deeperr0

Posted

@hl-wong Thank you for the tip. Is there any particular reason why it is better to have the span tag inside the p tag or is it just the convention?

0
HL Wong 290

@hl-wong

Posted

@Deeperr0 Sorry for the late reply. What I know is <span> tag is often used to apply specific style, example like you want to change the color of certain text in the <p> tag, then you need to put <span> tag inside the <p> to change it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord