@Ahmed-Elbald
Posted
Hello there,
I think you did a great job with this challenge. I just have some notes that might find helpful:
-
You need to increase spacing between elements a little bit as, right now, your elements are crushed into small space.
-
Your solution lacks some features when it comes to accessibility. You should wrap the whole card in an
article
element as it seems like a standalone element (it gives meaning on its own). -
In a real-world application, the text "Equilibrium #3429" won't be your
h1
. Therefor, I suggest using anh2
orh3
for that. -
When presenting the price and the days left, you can use a
dl
element whereas hiding the terms using a.visually-hidden
class, so that it makes sense for disabled users. It should be something like that:<dl> <dt class='visually-hidden'>Product price</dt> <dd>0.041ETH</dd> <dt class='visually-hidden'>days left</dt> <dd>3 days left</dd> </dl>
You can find more about the
dl
element here. You can also read about the.visually-hidden
class here
Marked as helpful
@SheikBazith
Posted
@Ahmed-Elbald thank you so much. dl tag sounds really helpful. I will work more on that. I am still not sure how to create layout of designs as I feel that's the hardest part. So using where to use article, main, etc. is bit confusing. Will work more on it.
If possible can u send some tutorial which can help me work on point 2 which is accessibility of the layout.
@Ahmed-Elbald
Posted
@SheikBazith
Unfortunately, most tutorials focus on creating the design and making it look good for normal users. There's almost no tutorials talking about accessibility in a serious and organized way.
I would see this is the only video on YouTube that is worth watching concerning that matter. However, I think the HTML Spec is your only friend here. It has all that you want to know.
@SheikBazith
Posted
@Ahmed-Elbald I agree. Most tutorial teach us how to make it look more attractive rather than make it more accessible. Will check the links u sent. Thanks