@CharlieeLuna23
Posted
Congrats and nice job!
One thing I can mention is that the you should not call the last div in the card "footer" as "footer" as it is actually the attribution at the bottom of the page which should be in the <footer> tag. I used "Creator" for that bit.
Regarding margin, I would not advise to use margin as a tool to center the card. For most of these projects I just used display: flex combined with other elements to center the content.
I'm no expert myself so take this with a grain of salt but it is what I was able to find.
@jjvega86
Posted
@CharlieeLuna23 -- thank you so much for the feedback! Great idea to just use Flexbox to make the <main> element a flex container to center the component, and great catch on my misuse of the "footer" class there - makes sense and gives me some ideas on how I can improve naming of classes so they don't collide with the semantics reserved for other parts of the document. Cheers!
