NFT Component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello Jeremy Lloyd, congratulations for your new solution!

  Your solution is great, the card is beautiful, the content is fine, the design too. All you miss here is to align the nft card vertically:

  To do that you need to remove the margins from the container and add min-height: 100vh to make the container align to the body height.

  See the code changes below:

  body {
      min-height: 100vh;
      background-color: hsl(217, 54%, 11%);
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
  }
  
  main {
      background-color: hsl(216, 50%, 16%);
      width: 350px;
      height: 600px;
      padding: 25px;
      /* margin: 25px auto 100px auto; */
      border-radius: 20px;
      display: flex;
      flex-direction: column;
      justify-content: space-between;
      box-shadow: 0px 20px 0 15px hsl(216deg 58% 10%), 0px 20px 0 40px hsl(216deg 58% 10% / 40%);
  }
  

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Jeremy Lloyd•310

  @jeremylloydPosted over 2 years ago

  @correlucas using the min-height is a great idea, I was previously using calc in the height property so your suggestion is much cleaner. Thanks!

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Jeremy Lloyd,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason , you can use <a> to wrap Equilibrium #3429.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative svgs, each svg tag should have aria-hidden="true" and focusable=”false” attributes to make all web assistive technologies such as screen reader ignore those svgs in(icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For middle part of the card class='price-status' , you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Hopefully this feedback helps.

  0