Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT component

Muhammad Danishβ€’ 200

@believer-danish

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Made this project responsive without using media queries. Please review and suggest any improvement.

Community feedback

Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @believer-danish!

Your solution looks great!

I have a suggestion for improvement:

  • Use <main> to wrap the whole main content instead of just the text. This tag is meant for the main content, including images, videos or any other elements that are part of it.

This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0

Muhammad Danishβ€’ 200

@believer-danish

Posted

@danielmrz-dev thanks for your suggestion. I will try to use semantic elements more efficiently.

1
Olaniyi Ezekielβ€’ 7,600

@Ezekiel225

Posted

Hello there πŸ‘‹ @believer-danish.

Good job on completing the challenge !

Your project looks really good!

I have a suggestion about your code that might interest you.

There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

I hope this suggestion is useful for future projects.

Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! πŸš€πŸŒŸ.

Other than that, great job!

Happy coding.

Marked as helpful

0

Muhammad Danishβ€’ 200

@believer-danish

Posted

@Ezekiel225 Thanks, I didn't knew about Perfect Pixel. Surely i will use it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord