Design comparison
Solution retrospective
A redo of the nft card component challenge. On my first attempt I had everything up until it came to putting the blue overlay of the image, so I had a friend who was an experienced developer help me with that part. I decided to do it again from scratch to get a better understanding and was able to learn a lot from having outside help and doing it a second time myself. This is that second attempt, the first attempt with my friend's changes is under "nft" on my github page. Shoutout to @jon-luke
Community feedback
- @RioCantrePosted almost 3 years ago
Hello there! Good job with this project. Viewing your solution, I would suggest the following for you..
- Adjust the font size for the
.nft-tag p
into 22px, it's better to useh1
in this part - Instead of using
table
, alternative is unordered listul
andli
orp
andspan
and use Flexbox for the alignment
Hope this helps and Keep it up! Cheers!
0 - Adjust the font size for the
- @NaveenGumastePosted almost 3 years ago
Hay ! Good Job you made it look nearly perfect to the preview
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body like it should be your container
-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc
-> But use header tag only once in main heading element.
Keep up the good work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord