NFT card with html5 and custom css properties

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @zeerobit~

  Congratulate on your solution to the challenge here. I have studied your work, and learned a lot from it. Especially trying BEM was wonderful!

  Here are some of the tips I can find on this one.

  1. Why didn't you add transition to link hover effects? That could make things better.
  2. On BEM using, I think card-image__items would be more useful than card_image__items.
  3. Creator name should be in one row on smaller devices.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH Here is my solution to this challenge, and if it can help you even a bit, it would be really happy to me.

  Happy coding!

  Marked as helpful

  2

  ---

  

  Heli0s•670

  @zeerobitPosted almost 3 years ago

  @tymren608 About the transition for the hover effect i did added it, is there something i'm missing?

  good catch about the creator name , i didn't test it for device under 360px size, it should be fixed now

  Appreciate the feedback.

  0