Skip to content
Submitted 5 months ago

nft card with BEM

tortaruga•450
@tortaruga
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

it was easy and quick to do, but that's just because it was a very simple layout with no js involved. It's my first time using bem, so i'm still not that confident with it and i'm not sure i used it correctly, I'll keep practicing.

What challenges did you encounter, and how did you overcome them?

nothing in particular, for once

What specific areas of your project would you like help with?

any feedback will be appreciated and treasured

Community feedback

  • Daniel 🛸•44,310
    @danielmrz-devPosted 5 months ago

    Hello, @tortaruga!

    Your solution looks great!

    I jus noticed that every element on your HTML has a before and after elements. This part of your code is causing this behavior:

    *::before, *::after {
    position: absolute;
    content: " "; /* remove this line */ ❌
}

    It's happening because you added an empty string as content for them, so you just need to remove the line and they will disappear from your HTML.

    I hope it helps!

    Other than that, you did an amazing job!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord