NFT card using only HTML and CSS

Community feedback

• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey @um1chc5, Congratulations on completing this challenge!

  Here is my feedback:

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  Keep doing a good job!

  Marked as helpful

  0

  ---

  

  um1chc5•210

  @um1chc5Posted about 2 years ago

  @Deolabest Thanks very much for your feedback. I will remember to do this in next project, very helpful!

  0

  

  um1chc5•210

  @um1chc5Posted about 2 years ago

  @Deolabest Thanks very much for your feedback. I will remember to do this in next project, very helpful!

  0
• 

  Adriano•38,040

  @AdrianoEscarabotePosted about 2 years ago

  Hi um1chc5, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology
  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  The rest is great!

  I hope it helps... 👍

  0