Design comparison
Solution retrospective
Hello please give some feedback
Community feedback
- @anoshaahmedPosted almost 3 years ago
To avoid accessibility issues in the future:
- wrap everything in your body in <main>
- start your headings with h1 and move up by one level each time
- give ur <img> and alt=""
Good job! :)
Marked as helpful1@JimCarey08Posted almost 3 years ago@anoshaahmed Thank you very much, i'll remind these!
1 - @ValeriaMontoyaPosted almost 3 years ago
Hi Lucas. My first tip to you is that you should use classes instead of id's for your CSS selectors, this is due to id's are more used to work with JavaScript. Another thing I recommend to you is to import the fonts from Google Fonts and add them in your HTML file instead of adding them in your CSS file. That way your page will have a better performance. Also try not to mix CSS styles on the HTML file because it's not a good practice (this has to do with specificity). I hope my tips help you, good luck! ☺️
Marked as helpful1@JimCarey08Posted almost 3 years ago@ValeriaMontoya THXX a lot, i'll remember these tips!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord