nft card using html & css

Community feedback

• 

  T

  Josh•400

  @burrijwPosted over 1 year ago

  Good start!

  • Check your <link> to the normalize.css file. There's an error: "space is not allowed".
  • There’s horizontal overflow at 320px wide. This is inaccessible per the WCAG 2.1.
  • You have a lot of things wrapped in <div> tags unnecessarily. Try to only use them when you need to for styling or scripting.
  • You don't need that div for the line. It's possible to use a border on the element before or after it instead. Or use a pseudo-element to keep your markup clean.

  Marked as helpful

  1

  ---

  

  mohamed nasr•160

  @stitch-606Posted over 1 year ago

  @burrijw
  my link is the correct file name is indeed "normalize css.css", thx for the rest tips I will avoid them next time :)

  0

  

  T

  Josh•400

  @burrijwPosted over 1 year ago

  @stitch-606 It may be the correct file name, but the file name should not contain spaces. The browser may understand it, but that could change in the future, other browsers might stop supporting it, etc. It'd be best practice to future-proof your code by following standards. 🤝🏻

  Marked as helpful

  0

  

  mohamed nasr•160

  @stitch-606Posted over 1 year ago

  @burrijw ok, thanks I did not know that :")

  0