Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Sudarsh, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - To make it look as close to the design as possible add
border-radius: 1rem; and overflow: hidden;
to#thumbnail
id - remove all
margin
fromcard
class - remove all
padding
from body - try to use flexbox to the body for center the card. Read here -> best flex guide
- after add
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent container - try to add a little
transition
on the element with hover effect
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1 - add
- @imhayatunnabiPosted over 2 years ago
nicely done
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord