Design comparison
SolutionDesign
Community feedback
- @rsrclabPosted almost 3 years ago
Hi, @surfruit ~
Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Especially I like the image overlay effect on your project. Especially I like BEM structuring on your project.
Here are some of the tips I like to provide.
- On smaller devices, card goes over screen, and I think
max-width: 100%
can solve this issue. - Please try BEM for naming element classes. It will help you a lot on bigger projects.
- There is no hover effects on image and other elements. It's also one of challenging part here.
- Font sizes and spacings aren't the same with design. As a front-end developer, it's important to meet pixel-perfect requirements.
- Width attribute of mage tags must be merely numbers.
https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH
Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.
Cheers ~
Marked as helpful0 - On smaller devices, card goes over screen, and I think
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord