Design comparison
Solution retrospective
Hola, hice esta tarjeta utilizando bootstrap y sass, queria poner en práctica el uso de landmarks de HTML5, pero quizá me falta entender mejor la distribución de cada elemento. Cualquier comentario es bienvenido, gracias por ver 😁
Community feedback
- @faha1999Posted about 2 years ago
Hello, Arturo Torres Flores Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:
- add style inside of head. Just like below.
<head> </head>
-
add favicon
<link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png">
-
remove
margin: 8%
frommain
& addmin-height:100vh
-
Instead of using
px
, use relative units likerem or em
to get better performance when the information on your page needs to be resized for multiple screens and devices.REM
andEM
apply to all sizes, not justfont-size
. You can code your entire page inpx
and then, at the very end, use the VsCode pluginpx to rem
to perform the automatic conversion px to rem
I hope it will work. Happy coding.
Marked as helpful0@Arturo9314Posted about 2 years ago@faha1999 Thank u so much for tips. I replace the code and it looks great!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord