Design comparison
SolutionDesign
Community feedback
- @iprinceroyyPosted over 2 years ago
Hey @PriyankaArikatla1205, you did great work but you need to do some more stuff. So here are my points to be focused on
- Don't use id as a selector. It's a bad practice. Use class as a selector
- img tag must have alt attributes for the people with disabilities.
- Hover state is not working. You should add some HTML markup & CSS rules for it. You can prefer my solution for reference.
- Always use relative units instead of px for better scalability. 1rem = 16px
I hope you find it helpful & it adds to your learning. Happy coding :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord