NFT Card Solution

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello again Phúc, congratulations for your new solution!

  I used this tutorial to build the hover effect, maybe it can help you to fix your solution: https://www.w3schools.com/howto/howto_css_image_overlay_icon.asp

  Fix the border-radius that is missing in the image: border-radius: 16px;

  .image {
      display: block;
      width: 100%;
      border-radius: 16px;
      height: auto;
      transition: 0.3s ease-in;
  }
  

  👋 I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Phúc (Scott) Nguyễn•430

  @NationsAnarchyPosted over 2 years ago

  @correlucas Thanks Lucas! I mean the avatar of the creator by the way, not the actual image of the NFT. I was able to do the hover effect (without the view icon). I'll look at that again in a later time :D

  1
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Phúc (Scott) Nguyễn,

  Congratulation on completing this challenge.

  Excellent work again! I have few suggestions regarding your solution, if you don't mind:

  1. The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
     1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>. For the same reason, use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  2. The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  3. For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  4. look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  5. If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  6. To use more semantic tags, you may use <figure> and <figcaption> for the avatar's part.

  7. The alternate text of the avatar’s image should not be Avatar of the creator, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  8. For middle part of the card class="pricing-container", you can use an unordered list <ul>, in each <li> there should be <img> and <p> that way you can align them centrally.

  There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  • Last , the hover effects are missing on the interactive elements.

  Aside these, great job on this one. hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Phúc (Scott) Nguyễn•430

  @NationsAnarchyPosted over 2 years ago

  @PhoenixDev22 Yeah you're right - I forgot to check the interaction design, that's why I was missing some of the interactive things. I guess I'll add them later on.

  Thank you for the very detailed comment as always! I guess I still miss a lot of details (since, again I made this solution in a rather quick time) and comments like yours will definitely help me a ton :D

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @NationsAnarchy Glad it was helpful, Happy coding!

  1