NFT Card SASS Partials

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @onlydominik!

  Your solution looks excellent!

  I have just one suggestion:

  • Use <main> to wrap the main content instead of <section>.

  📌 The tag <section> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  Hello there, Congratulations on completing this project

  Your solution looks nice

  I have few suggestions that I think might be of interest to you.

  - HTML: Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <section class="card"> with <main class="card">. the main tag should hold the main content of the page so consider correcting that.

  I hope this feedback is helpful

  Other than that great job

  0