nft card responsive

Community feedback

• 

  P

  Srijan Manandhar•470

  @srijanssPosted about 2 months ago

  • You have used landmark components like main and footer , however using article or section for card element would've been more semantic. Level 1 heading is missing for you page, so you can change h2 to h1 in your card
  • There are two links in the solution, but they were not accessible using keyboard. You can change the Heading and author name to link so that it takes default focus on keyboard Tab press
  • The solution differs a bit from the design, with some padding and margin fixes it will match the design
  • I followed BEM methodology to define CSS classes for this solution, its really helpful to write and manage modular CSS

  Marked as helpful

  1