NFT Card Preview using HTML CSS and Javascript

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Nice job in completing this project. Regarding your solution, I would like to recommend the following for you…

  • Add the hover state of the design. For the hero image , refer it with this one Overlay in image
  • Wrap the whole content with specific tag like main and attribution with footer tag. For HTML structures, refer it with this one Semantics
  • Include description with the alt in image tags. Like this line <img id="mainTheme" src="./images/image-equilibrium.jpg" alt="">
  • Import the attribution style in CSS file and remove the style tag
  • Remove unnecessary code to keep it clean
  • Add display: flex; and justify-content: center; in .info span:nth-of-type(1) and .info span:nth-of-type(2) to align the icons with the text. Add margin or padding between them as well.

  Above all, the project is done well. Keep up the good work and Hope this is helpful!

  Marked as helpful

  2

  ---

  

  Gabi•280

  @GaboczPosted over 2 years ago

  @RioCantre Thank you for the suggestions! I will try to re-work the project using them!

  2
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  Hay ! Gabi Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  1
• 

  Wesley kaihara•60

  @WesleyKaiharaPosted over 2 years ago

  Hello, maybe to solve the problem of the flickering image you could put in #overlay{ transition:all .5s; }

  https://developer.mozilla.org/pt-BR/docs/Web/CSS/transition

  Marked as helpful

  1

  ---

  

  Gabi•280

  @GaboczPosted over 2 years ago

  @WesleyKaihara Thank you, I will try that!

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted over 2 years ago

  Great work overall man. Keep it up

  1

  ---

  

  Gabi•280

  @GaboczPosted over 2 years ago

  @Phalcin Thank you man! I am a complete beginner so any incouragement is welcome. :-)

  0