NFT card preview using HTML and CSS

Community feedback

• 

  dimar hanung•560

  @dimar-hanungPosted over 1 year ago

  Hello! 🖐️ Well done on completing the challenge

  I have some interest and feedback with your code

  That i like:

  1. I appreciate the similarity of your results with the design, a bit different in font color and shadow but still good
  2. html is pretty good, not too nested 👍
  3. Responsive until galaxy fold screen size 👌
  4. CSS Naming is also good, represent what is it for, like <div class="details"> for details section

  My Feedback:

  • I suggest you use html semantic convention, for example <div class="container__ext"> to <main class="container__ext">, it will make it clearer, and will improve seo if you want to submit your website to google, but you place h1 and p correctly 👌, i recomended this article: here
  • You can set font color #8BACD9 for class : .text .second__p .third__p
  • Shadow is too bold, you can use this to make it more smooth box-shadow: 0 25px 50px #00000018

  anyways overall is good, nice solution, hope it's helpful 🙌

  Marked as helpful

  0

  ---

  

  Claudiu Sonica•150

  @ClaudiuSonicaPosted over 1 year ago

  @dimar-hanung thank you for the feedback, to be honest i forgot about the other phone types and made it for 375px and 700px+ and the shadow personally i liked better that way lol :)). But thanks for the heads up

  0

  

  dimar hanung•560

  @dimar-hanungPosted over 1 year ago

  @ClaudiuSonica

  you're welcome!, yes no problem, everyone has different preferences

  0