Design comparison
SolutionDesign
Solution retrospective
There was a little bit of difficulty with the image:hover section. I think it's a fun challenge in the end. I would appreciate any feedback you may have.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- For elements with a hover effect in the design, consider enclosing them within an a (anchor) tag for better semantics and accessibility
- Use an empty
alt
attribute (alt=""
) for icons to signal their decorative nature to assistive technologies.
- You've applied
align-items: center
andjustify-content: center
to the body element, but you might be missing the crucialdisplay: flex.
Without this property, thealign-items
andjustify-content
won't take effect. Also, useflex-direction: column
to ensure that items are centered vertically in a column.
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource ๐.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord