Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Nft card preview - Flexbox and :hover

@DavidCasanova83

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Do you have some tips for found the perfect px size of an element just with the images from design folder ? And without figma ?

Community feedback

PhoenixDev22ā€¢ 16,950

@PhoenixDev22

Posted

Hello @DvD83130 ,

I have some suggestions regarding your solution:

  • Using landmark elements , you can improve the navigation experience on your site for users of assistive technology . So you can use<main> to wrap the body content

  • Links must have discernible text . you can have the main image Equilibrium in the html .

  • For any decorative images, each img tag should have empty alt="" andaria-hidden="true"attributes to make all web assistive technologies such as screen reader ignore those images as in alt="icon-ethereum" , alt="icon-ethereum" Read about how and when to write image alt text and what it's for..

  • It's invalid html to wrap a heading element in an anchor tag. Swap those around so the anchor is inside the heading.

  • Do not include a prefix such as "profil-author-pictures" the screen reader will communicate the fact that this element is an image as it has been coded as such. You can useJules Wyvernas alt text .

  • You can use flexbox properties and min-height to the body( not height )to center the component on the middle of the page.(no need for position absolute)

{
display: flex;
align-items: center;
justify-content : center ;
width: 100%;
min-height: 100vh
}
  • Never have font size in px. Using px won't allow the user to control the font size based on their needs.

  • Use max-width instead of width. Then a little margin on the component or padding on the body to stop it hitting screen edges

Hopefully this feedback helps.

Marked as helpful

0

@DavidCasanova83

Posted

Duuude !!! thanks a lot for your comment ;) I Love it, many goods suggestions. You improve my knowledge, just perfect.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord