NFT Card Preview Component | HTML CSS Sass

Community feedback

• 

  Emmiecodes•100

  @EmmiecodesPosted about 2 years ago

  Hello Vanza,

  I was doing the order-summary challenge and was trying to focus more on accesibility doing so, and I came across the issue of having to use a div for the subscription plan and price part so I started googling the use of the role attribute and a ton of other things and came across your page that way. I saw you also used a div for the same part as I did, without adding a role attribute to it for screenreader users to make sense of the div. (I had no clue what role to add when I looked them up)

  Afterwards I went looking at your NFT card solution which did help me out with realizing I could use the figure and figcaption with flex styling too, and aside from that there are some nice accesibility features you have, I had not thought about or seen before, like adding the abbrevation (before I had no clue what ETH was either) and the custom focus effect on your order summary. I like how you normalize accesibility in your code and the questions you ask on here, that should be an example for all. I was wondering though why you chose to use UL's for the currency and days left part instead of divs and why you didn't do so for the subscription info/costs in the order summary? And if you deliberately chose to keep your alt="" descriptions short? It makes me think about how meaningful those images really are to screenreader users or non screenreader users wanting to buy crypto and wonder if my alt descriptions are too long for this context. (Eg: white boy with brown hair, bangs and cream colored shirt)

  Marked as helpful

  0

  ---

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @Emmiecodes

  Hey there! Thank you for the comment! 🙂

  I made some changes to the HTML. So, I decided to use p element instead of a list element. I think it doesn't make sense for those content to be rendered as a list.

  For the alternative text of the avatar, I recommend using the author's name. It is an important thing that users need to know rather than the styling of the avatar.

  1
• 

  P

  David Turner•4,150

  @brodiewebdtPosted almost 3 years ago

  This looks very good. I have gotten to the point that I look at spacing and alignment on every site I go to. This really looks good. The TAB key works here.

  Marked as helpful

  0

  ---

  

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  @brodiewebdt 😊 Thanks for your compliment! Glad to know that you can navigate through the website using keyboard!

  1
• 

  Alex•660

  @al3xbackPosted almost 3 years ago

  Hi Vanza,

  I believe there is an inconsistency in your css, esp using single colon on pseudo element.

  img:after {
      ...
  }
  

  Marked as helpful

  0

  ---

  

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  @al3xback Yeah, I have added one more colon to it. Thanks for pointing that!

  1
• 

  P

  David Turner•4,150

  @brodiewebdtPosted almost 3 years ago

  Your welcome.

  0