@PhoenixDev22
Posted
Hi Kenisa,
Congratulation on completing this challenge.
Excellent work! I see you have received some incredible feedback .If you don't mind, I have few suggestions regarding your solution:
HTML
-
The icon-view doesn’t really need to be in the HTML as there's need for extra clutter in the HTML . You can use CSS for it
-
The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you. -
For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attribute to make all web assistive technologies such as screen reader ignore those images in(icon-view, icon-ethereum, icon-clock
).
-
If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<div class="hr"></div>
, you can useborder-top:
to the avatar's part. -
To use more semantic tags , you may use
<figure>
and<figcaption>
for the avatar's part. -
The avatar's alt should not be creator profile pictureit’s meaningless. You can use the creator's name
Jules Wyvern
. Read more how to write an alt text -
For middle part of the card
class="details"
, you can use an unordered list<ul>
, in each<li>
there should be<img>
and<p>
that way you can align them centrally.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.
- Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.
Overall, Your solution is good. Hopefully this feedback helps.
Marked as helpful